Skip to content

Update managed cluster upgrades#5789

Merged
dsgouda merged 2 commits intoAzure:dev-containerservice-Microsoft.ContainerService-2019-04-01from
gtracer:dev-containerservice-Microsoft.ContainerService-2019-04-01
Apr 29, 2019
Merged

Update managed cluster upgrades#5789
dsgouda merged 2 commits intoAzure:dev-containerservice-Microsoft.ContainerService-2019-04-01from
gtracer:dev-containerservice-Microsoft.ContainerService-2019-04-01

Conversation

@gtracer
Copy link
Copy Markdown
Contributor

@gtracer gtracer commented Apr 29, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 29, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 29, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 29, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 29, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 29, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Apr 29, 2019

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from dsgouda April 29, 2019 17:08
@xizha162
Copy link
Copy Markdown
Contributor

xizha162 commented Apr 29, 2019

/LGTM

dsgouda
dsgouda reviewed Apr 29, 2019
View reviewed changes
...erservice/resource-manager/Microsoft.ContainerService/stable/2019-04-01/managedClusters.json
},
"description": "Identity for the managed cluster."
},
"OrchestratorProfile": {
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for a stable version. Were any SDKs published for this spec?

Copy link
Copy Markdown
Contributor Author

@gtracer gtracer Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda thanks for noting this. I don't believe spec 2019-04-01 has been published yet, so it should be ok.
@xizhamsft can you confirm that no SDKs were published for 2019-04-01? Also, Xiaofang, I removed it because I couldn't find any references to it

Copy link
Copy Markdown
Contributor

@xizha162 xizha162 Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda , We have not published the SDK using 2019-04-01 api-version. We do have SDK published for earlier api-versions like 2019-02-01. Would that be a problem?

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no SDKs have been published, we can move forward with these changes

@dsgouda dsgouda added potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Apr 29, 2019
dsgouda
dsgouda suggested changes Apr 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 1d5b5d9 into Azure:dev-containerservice-Microsoft.ContainerService-2019-04-01 Apr 29, 2019
xizha162 pushed a commit to xizha162/azure-rest-api-specs that referenced this pull request Apr 30, 2019
@gtracer
Update managed cluster upgrades (Azure#5789)
717e55f 
* Update managed cluster upgrades

* Fix syntax type error
@xizha162 xizha162 mentioned this pull request Apr 30, 2019
Merged
5 tasks
praries880 pushed a commit that referenced this pull request Apr 30, 2019
@praries880
Dev containerservice microsoft.container service 2019 04 01 (#5797)
0987d5a 
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (#5556)

* Add support VMSS agent nodes with public IP. (#5748)

* Add identity property in managedCluster definition and add an example (#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* node resource group can be read-write (#5762)

* Update managed cluster upgrades (#5789)

* Update managed cluster upgrades

* Fix syntax type error

* including 2019-04-01 api version in 2019-04 package

* remove the unreferenced MSIManagedClusterCreate_Update.json file

* fixing typo per comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@xizha162 xizha162 xizha162 left review comments

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gtracer @AutorestCI @azuresdkci @xizha162 @dsgouda